On Mon, Apr 15, 2019 at 04:29:01PM +0100, Willy Wolff wrote: > Thank you for your review. > > I follow https://kernelnewbies.org/FirstKernelPatch to write this patch. > It's not stated that checkpatch.pl is for new patches only. Moreover, > https://kernelnewbies.org/FirstKernelPatch#Running_checkpatch.pl suggest to > run over the entire file.
FirstKernelPatch is a good thing to do in drivers/staging/, not anywhere else in the kernel tree unless you _KNOW_ the maintainer of that subsystem is ok to take tiny cleanup patches like this. thanks, greg k-h
