Hi Simon, On Tue, Apr 23, 2019 at 12:01:07PM +0200, Simon Horman wrote: > On Tue, Apr 16, 2019 at 07:48:30PM +0200, Eugeniu Rosca wrote: > > Hi Jiada, > > > > Adding below people, since they've made recent contributions to the > > driver and might be interested in your patch: > > > > git log master --since="1 year" -- drivers/thermal/rcar_gen3_thermal.c \ > > | grep -o "\-by:.*" | sed 's/\-by: //' | sort | uniq -c | sort -rn > > 7 Eduardo Valentin <[email protected]> > > 6 Simon Horman <[email protected]> > > 5 Niklas Söderlund <[email protected]> > > 2 Geert Uytterhoeven <[email protected]> > > 1 Sergei Shtylyov <[email protected]> > > 1 Marek Vasut <[email protected]> > > 1 Kuninori Morimoto <[email protected]> > > 1 Hien Dang <[email protected]> > > 1 Fabrizio Castro <[email protected]> > > 1 Dien Pham <[email protected]> > > 1 Daniel Lezcano <[email protected]> > > 1 Biju Das <[email protected]> > > > > I confirm that loading and unloading the rcar3 thermal driver in a > > loop produces soft lockup using v5.1-rc5-10-g618d919cae2f on > > H3-ES2.0-Salvator-X. > > > > Full log and .config can be found here: > > https://gist.github.com/erosca/1f76b6dd897cdc39581fca475155e363 > > > > I post an excerpt from the above [1] (why not including it in the > > description?). Also, why not rephrasing the commit summary line in such > > a way that everybody understands this patch fixes a severe issue, e.g. > > "thermal: rcar_gen3_thermal: Fix soft lockup on probe" ? > > > > BTW, with this patch applied I left the thermal driver being > > loaded/unloaded on the target for over one hour w/o seeing the issue > > reproduced. So, while there might be slight variations in how the final > > solution looks like, I think the patch already deserves a: > > > > Tested-by: Eugeniu Rosca <[email protected]> > > > > [1] Soft lockup reproduced with v5.1-rc5-10-g618d919cae2f > > Thanks, > > Unfortunately I do not see the patch in my inbox. > Would you care to repost it including the following recipients. > > [email protected] > Zhang Rui <[email protected]> > Eduardo Valentin <[email protected]> > [email protected] > Niklas Söderlund <[email protected]> > > Feel free to include the suggestions made by Eugeniu above and post a v2.
There is a v2 pushed recently: https://patchwork.kernel.org/cover/10911999/ ("[v2,0/2] thermal: rcar_gen3_thermal: fix IRQ issues"). It seems to include both the preparatory work suggested by Daniel in https://patchwork.kernel.org/patch/10895557/#22592583, as well as the soft lockup fix itself. Best regard, Eugeniu.
