On Mon, Apr 15, 2019 at 09:37:23AM +0000, Anup Patel wrote: > This patch adds SCAUSE interrupt flag and SCAUSE interrupt related > defines to asm/csr.h. We also use these defines in kernel/irq.c and > express SIE/SIP flags in-terms of SCAUSE interrupt causes.
I'm not a fan of this. For one this pollutes csr.h with bits not really needed by most users, and it makes adding the M-mode nommu port which has to use the M-mode causes much harder: http://git.infradead.org/users/hch/misc.git/commitdiff/1221f5c32345ebe7ea2c1cd6e8a01ad4b422aaba