On 4/30/19 3:32 PM, Rob Herring wrote:
On Tue, Apr 30, 2019 at 09:15:42AM -0700, Guenter Roeck wrote:
On Mon, Apr 29, 2019 at 11:45:57PM -0700, Andrey Smirnov wrote:
Add bindings for Microchip UCS1002 Programmable USB Port Power
Controller with Charger Emulation.

Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Enric Balletbo Serra <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: Sebastian Reichel <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
  .../power/supply/microchip,ucs1002.txt        | 27 +++++++++++++++++++
  1 file changed, 27 insertions(+)
  create mode 100644 
Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt

diff --git 
a/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt 
b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt
new file mode 100644
index 000000000000..021fd7aba75e
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt
@@ -0,0 +1,27 @@
+Microchip UCS1002 USB Port Power Controller
+
+Required properties:
+- compatible           : Should be "microchip,ucs1002";
+- reg                  : I2C slave address
+
+Optional properties:
+- interrupts-extended  : A list of interrupts lines present (could be either
+                         corresponding to A_DET# pin, ALERT# pin, or both)

Just make this 'interrupts'. Support for 'interrupts-extended' is
implied.

With that,

Reviewed-by: Rob Herring <[email protected]>

+- interrupt-names      : A list of interrupt names. Should contain (if
+                         present):
+                         - "a_det" for line connected to A_DET# pin
+                         - "alert" for line connected to ALERT# pin
+                         Both are expected to be IRQ_TYPE_EDGE_BOTH
+Example:
+
+&i2c3 {
+       charger@32 {
+               compatible = "microchip,ucs1002";
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_ucs1002_pins>;

Document the above ? Or is that optional ?

I would have said to document this, but recently we had some discussion
about allowing this to be implied when there's only a 'default' entry.
We'll add it automatically for schemas.


Good to know. Thanks for the information!

Guenter

Reply via email to