From: Colin King <[email protected]> Date: Wed, 8 May 2019 14:30:41 +0100
> From: Colin Ian King <[email protected]> > > The while-loop exit condition check is not correct; the > loop should continue if the returns from the function calls are > negative or the CRC status returns are invalid. Currently it > is ignoring the returns from the function calls. Fix this by > removing the status return checks and only break from the loop > at the very end when we know that all the success condtions have > been met. > > Kudos to Dan Carpenter for describing the correct fix and > Vladimir Oltean for noting the change to the check on the number > of retries. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 > switch") > Signed-off-by: Colin Ian King <[email protected]> > Tested-by: Vladimir Oltean <[email protected]> Applied, thank you.
