On Fri, 24 May 2019 06:05:36 +0200 Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote:
> On Fri, May 24, 2019 at 4:12 AM Steven Rostedt <rost...@goodmis.org> wrote: > > > > On Thu, 23 May 2019 14:45:35 +0200 > > Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote: > > > > I still prefer the typecast of void *, as that's used a bit more in the > > kernel, but since char * is also used (not as much), I'll leave it. But > > the parenthesis around iter are unnecessary. I'll remove them. > > If the preferred style in the kernel is void *, change it on your > side, please! :-) Maybe we should mention it in the coding guidelines. > Well, it's not officially the preferred style. There's 240 uses of (void *) in memset, compared to 98 uses of (char *) $ git grep memset | grep '(void \*)' | wc -l 240 $ git grep memset | grep '(char \*)' | wc -l 98 I was about to make the conversion, but when I added addition to the equation, the (char *) went ahead slightly: $ git grep memset | grep '(void \*)' | grep '+' | wc -l 32 $ git grep memset | grep '(char \*)' | grep '+' | wc -l 35 Both are fine and legit, but as the weight is slightly higher doing byte arithmetic with char *, I'll keep it as is. -- STeve
