RE: [PATCH net-next v4 1/5] net: stmmac: enable clause 45 mdio support

[Jose Abreu]

From: Voon Weifeng <weifeng.v...@intel.com>
Date: Wed, May 29, 2019 at 17:58:23

> +static void stmmac_mdio_c45_setup(struct stmmac_priv *priv, int phyreg,
> +                               u32 *val, u32 *data)
> +{
> +     unsigned int reg_shift = priv->hw->mii.reg_shift;
> +     unsigned int reg_mask = priv->hw->mii.reg_mask;

Reverse christmas tree here. You also should align the function variables 
with the opening parenthesis of the function here and in the remaining 
series.

Otherwise this patch looks good to me.

Thanks,
Jose Miguel Abreu