Commit-ID:  2d45ef7033ec90104ae8e4c3996227bdad24dc76
Gitweb:     https://git.kernel.org/tip/2d45ef7033ec90104ae8e4c3996227bdad24dc76
Author:     Arnaldo Carvalho de Melo <a...@redhat.com>
AuthorDate: Mon, 20 May 2019 11:04:08 -0300
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Tue, 28 May 2019 18:37:45 -0300

perf top: Lower message level for failure on synthesizing events for 
pre-existing BPF programs

Move it from being a pr_warning() to a pr_debug(). Also capitalize BPF
and explain what gets missing when we're not able to synthesize these
events: we'll not be able to resolve symbols, etc.

Reported-by: Ingo Molnar <mi...@kernel.org>
Cc: Adrian Hunter <adrian.hun...@intel.com>
Cc: Alexei Starovoitov <a...@fb.com>
Cc: Andrii Nakryiko <andrii.nakry...@gmail.com>
Cc: Daniel Borkmann <dan...@iogearbox.net>
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Luis Cláudio Gonçalves <lclau...@redhat.com>
Cc: Martin KaFai Lau <ka...@fb.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Song Liu <songliubrav...@fb.com>
Cc: Wang Nan <wangn...@huawei.com>
Cc: Yonghong Song <y...@fb.com>
Link: https://lkml.kernel.org/n/tip-whpnfnw6xtd939odgt9bw...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/builtin-top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 31d78d874fc7..6651377fd762 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1215,7 +1215,7 @@ static int __cmd_top(struct perf_top *top)
                                                &top->session->machines.host,
                                                &top->record_opts);
        if (ret < 0)
-               pr_warning("Couldn't synthesize bpf events.\n");
+               pr_debug("Couldn't synthesize BPF events: Pre-existing BPF 
programs won't have symbols resolved.\n");
 
        machine__synthesize_threads(&top->session->machines.host, &opts->target,
                                    top->evlist->threads, false,

Reply via email to