> On May 31, 2019, at 3:17 AM, Peter Zijlstra <[email protected]> wrote: > > On Thu, May 30, 2019 at 11:36:40PM -0700, Nadav Amit wrote: >> cfd_data is marked as shared, but although it hold pointers to shared >> data structures, it is private per core. >> >> Cc: Peter Zijlstra <[email protected]> >> Cc: Thomas Gleixner <[email protected]> >> Cc: Rik van Riel <[email protected]> >> Cc: Andy Lutomirski <[email protected]> >> Signed-off-by: Nadav Amit <[email protected]> >> --- >> kernel/smp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/smp.c b/kernel/smp.c >> index 6b411ee86ef6..f1a358f9c34c 100644 >> --- a/kernel/smp.c >> +++ b/kernel/smp.c >> @@ -33,7 +33,7 @@ struct call_function_data { >> cpumask_var_t cpumask_ipi; >> }; >> >> -static DEFINE_PER_CPU_SHARED_ALIGNED(struct call_function_data, cfd_data); >> +static DEFINE_PER_CPU(struct call_function_data, cfd_data); > > Should that not be DEFINE_PER_CPU_ALIGNED() then?
Yes. I don’t know what I was thinking. I’ll change it.
