This set improves a few somewhat terse bonding debug messages, fixes some errors in others, and then standarizes the majority of them, using new slave_* printk macros that wrap around netdev_* to ensure both master and slave information is provided consistently, where relevant. This set proves very useful in debugging issues on hosts with multiple bonds.
I've run an array of LNST tests over this set, creating and destroying quite a few different bonds of the course of testing, fixed the little gotchas here and there, and everything looks stable and reasonable to me, but I can't guarantee I've tested every possible message and scenario to catch every possible "slave could be NULL" case. Jarod Wilson (7): bonding: improve event debug usability bonding: fix error messages in bond_do_fail_over_mac bonding: add slave_foo printk macros bonding/main: convert to using slave printk macros bonding/802.3ad: convert to using slave printk macros bonding/alb: convert to using slave printk macros bonding/options: convert to using slave printk macros drivers/net/bonding/bond_3ad.c | 222 +++++++++++---------- drivers/net/bonding/bond_alb.c | 30 +-- drivers/net/bonding/bond_main.c | 309 +++++++++++++---------------- drivers/net/bonding/bond_options.c | 30 ++- include/net/bonding.h | 9 + 5 files changed, 293 insertions(+), 307 deletions(-) Suggested-by: Joe Perches <[email protected]> CC: Jay Vosburgh <[email protected]> CC: Veaceslav Falico <[email protected]> CC: Andy Gospodarek <[email protected]> CC: [email protected] Signed-off-by: Jarod Wilson <[email protected]> -- 2.20.1
