On Mon, Jun 10, 2019 at 04:21:33PM +0530, Viresh Kumar wrote:
> In order to use dev_pm_qos_read_value(), and other internal routines to
> it, to read values for different QoS requests, pass request type as a
> parameter to these routines.
nit: I find that somewhat hard to parse, a possible improvement:
"In order to allow dev_pm_qos_read_value() and other {related,similar}
internal routines to read values for different QoS requests, pass
request type as a parameter to these routines."
(I'm not a native English speaker, so I don't claim this to be
correct ;-)
> For now, it only supports resume-latency request type.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> Documentation/power/pm_qos_interface.txt | 2 +-
> drivers/base/power/domain_governor.c | 4 +--
> drivers/base/power/qos.c | 10 +++---
> drivers/base/power/runtime.c | 2 +-
> drivers/cpuidle/governor.c | 2 +-
> include/linux/pm_qos.h | 41 +++++++++++++++++-------
> 6 files changed, 40 insertions(+), 21 deletions(-)
looks good to me, however I'm just a QoS n00b:
Reviewed-by: Matthias Kaehlcke <[email protected]>
