On Wed, Jun 12, 2019 at 05:41:22PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 12, 2019 at 05:18:56PM +0200, Borislav Petkov wrote:
> > On Wed, Jun 12, 2019 at 05:15:31PM +0200, Greg Kroah-Hartman wrote:
> > > When calling debugfs functions, there is no need to ever check the
> > > return value. The function can work or not, but the code logic should
> > > never do something different based on this.
> > >
> > > Cc: Thomas Gleixner <[email protected]>
> > > Cc: Ingo Molnar <[email protected]>
> > > Cc: Borislav Petkov <[email protected]>
> > > Cc: "H. Peter Anvin" <[email protected]>
> > > Cc: <[email protected]>
> > > Cc: Tony Luck <[email protected]>
> > > Cc: Vishal Verma <[email protected]>
> > > Cc: Pu Wen <[email protected]>
> > > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> > > ---
> > > arch/x86/kernel/cpu/mce/core.c | 16 +++++---------
> > > arch/x86/kernel/cpu/mce/inject.c | 34 +++++-------------------------
> > > arch/x86/kernel/cpu/mce/severity.c | 14 +++---------
> > > 3 files changed, 13 insertions(+), 51 deletions(-)
> >
> > I think I'm having a deja-vu:
> >
> > https://lkml.kernel.org/r/[email protected]
>
> Ah, I thought I had sent this out before...
>
> Anyway, I'll fix this up, but really, you will not have a debugfs file
> fail creation unless the system is totally out of memory...
Promise? :-P
I mean, I don't mind getting rid of all that error handling getting in
the way of the code but we'll leave the injector in a half-init state if
the allocation fails.
I guess I can take this and see what breaks. If it does, we can always
revert it...
Btw, is your aim to make debugfs_create_file() return void or you're
just doing some cleanups?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
