On Fri, Jun 14, 2019 at 08:09:19AM +0200, Greg KH wrote: > On Fri, Jun 14, 2019 at 12:27:05AM +0530, Saiyam Doshi wrote: > > Replace printk() with dev_* macros for logging consistency. > > In process of replacing printk with dev_err, dev_info etc., > > removed unnecessary "out of memory" debug message. > > That is multiple things done in the same patch, please break this up > into a patch series, only doing one "logical" thing per patch.
Agreed. I could have broken it into patch set. > Note, generic cleanup patches like this are tough to get done in the > "real" part of the kernel, I strongly recommend you start out in > drivers/staging/ where these types of changes are welcomed. Get > experience there and then move out into other areas of the kernel if you > want to, that way you don't annoy developers/maintainers with basic > errors like this. > > good luck! Noted. Thanks Greg for feedback and suggestion.
