On Tue 02-07-19 21:53:24, Pingfan Liu wrote: > undo_isolate_page_range() never fails, so no need to return value. > > Signed-off-by: Pingfan Liu <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: Michal Hocko <[email protected]> > Cc: Oscar Salvador <[email protected]> > Cc: Qian Cai <[email protected]> > Cc: Anshuman Khandual <[email protected]> > Cc: [email protected]
Acked-by: Michal Hocko <[email protected]> > --- > include/linux/page-isolation.h | 2 +- > mm/page_isolation.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h > index 280ae96..1099c2f 100644 > --- a/include/linux/page-isolation.h > +++ b/include/linux/page-isolation.h > @@ -50,7 +50,7 @@ start_isolate_page_range(unsigned long start_pfn, unsigned > long end_pfn, > * Changes MIGRATE_ISOLATE to MIGRATE_MOVABLE. > * target range is [start_pfn, end_pfn) > */ > -int > +void > undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, > unsigned migratetype); > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index e3638a5..89c19c0 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -230,7 +230,7 @@ int start_isolate_page_range(unsigned long start_pfn, > unsigned long end_pfn, > /* > * Make isolated pages available again. > */ > -int undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, > +void undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, > unsigned migratetype) > { > unsigned long pfn; > @@ -247,7 +247,6 @@ int undo_isolate_page_range(unsigned long start_pfn, > unsigned long end_pfn, > continue; > unset_migratetype_isolate(page, migratetype); > } > - return 0; > } > /* > * Test all pages in the range is free(means isolated) or not. > -- > 2.7.5 -- Michal Hocko SUSE Labs
