On Mon, Jul 29, 2019 at 01:42:42PM -0700, Matthias Kaehlcke wrote:
Hi,
On Mon, Jul 29, 2019 at 10:20:25PM +0200, Toralf Förster wrote:
May I ask you to clarify why
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/diff/queue-5.2/net-ipv4-fib_trie-avoid-cryptic-ternary-expressions.patch?id=e1b76013997246a0d14b7443acbb393577d2a1e8
speaks about a ternary operator, whereas the diff shows a changed
#define?
This is a good question, apparently the content of the queued patch is:
commit 4df607cc6fe8e46b258ff2a53d0a60ca3008ffc7
Author: Nathan Huckleberry <[email protected]>
Date: Mon Jun 17 10:28:29 2019 -0700
kbuild: Remove unnecessary -Wno-unused-value
however the commit message is from:
commit 25cec756891e8733433efea63b2254ddc93aa5cc
Author: Matthias Kaehlcke <[email protected]>
Date: Tue Jun 18 14:14:40 2019 -0700
net/ipv4: fib_trie: Avoid cryptic ternary expressions
Other than that the stable port also is missing a Signed-off-by tag
from Nathan.
Looks like the patch didn't actually make it into -stable yet? If that
is correct we should be in time to fix it up before it becomes part of
the git history.
Right, it was an issue with my script which is now fixed. I've also
fixed up the stable tree. Thanks for pointing it out.
--
Thanks,
Sasha