Hi Stephen, Le 31/07/2019 à 21:35, Stephen Boyd a écrit : > A future patch is going to change semantics of clk_register() so that > clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid > referencing this member here so that we don't run into NULL pointer > exceptions. > > Cc: Neil Armstrong <[email protected]> > Cc: Jerome Brunet <[email protected]> > Signed-off-by: Stephen Boyd <[email protected]> > --- > > Please ack so I can take this through clk tree > > drivers/clk/meson/axg-audio.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c > index 8028ff6f6610..db0b73d53551 100644 > --- a/drivers/clk/meson/axg-audio.c > +++ b/drivers/clk/meson/axg-audio.c > @@ -992,15 +992,18 @@ static int axg_audio_clkc_probe(struct platform_device > *pdev) > > /* Take care to skip the registered input clocks */ > for (i = AUD_CLKID_DDR_ARB; i < data->hw_onecell_data->num; i++) { > + const char *name; > + > hw = data->hw_onecell_data->hws[i]; > /* array might be sparse */ > if (!hw) > continue; > > + name = hw->init->name; > + > ret = devm_clk_hw_register(dev, hw); > if (ret) { > - dev_err(dev, "failed to register clock %s\n", > - hw->init->name); > + dev_err(dev, "failed to register clock %s\n", name); > return ret; > } > } >
Acked-by: Neil Armstrong <[email protected]>
