On 25-07-19, 18:39, Pierre-Louis Bossart wrote: > Not sure why the existing code would enable interrupts without the > ability to deal with them. > > Signed-off-by: Pierre-Louis Bossart <[email protected]> > --- > drivers/soundwire/intel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index aeadc341c0a3..68832e613b1e 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -981,8 +981,6 @@ static int intel_probe(struct platform_device *pdev) > if (ret) > goto err_init; > > - ret = sdw_cdns_enable_interrupt(&sdw->cdns); > - > /* Read the PDI config and initialize cadence PDI */ > intel_pdi_init(sdw, &config); > ret = sdw_cdns_pdi_init(&sdw->cdns, config); > @@ -1000,6 +998,8 @@ static int intel_probe(struct platform_device *pdev) > goto err_init; > } > > + ret = sdw_cdns_enable_interrupt(&sdw->cdns);
we should also handle the return -- ~Vinod
