Hi Shawn/Leo,

Removing the "big-endian" property has caused problems in our UEFI firmware.
In UEFI, we use the device tree to detect and use the qspi controller and 
flashes attached to it.
We don't maintain a list of platforms like linux driver.

Can you please revert the endianness change from linux mainline ?

Regards,
Pankaj Bansal

> -----Original Message-----
> From: [email protected] <[email protected]>
> On Behalf Of Schrempf Frieder
> Sent: Wednesday, 20 March, 2019 08:08 PM
> To: Shawn Guo <[email protected]>; Leo Li <[email protected]>
> Cc: Schrempf Frieder <[email protected]>; Rob Herring
> <[email protected]>; Mark Rutland <[email protected]>; linux-arm-
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI
> nodes
> 
> From: Frieder Schrempf <[email protected]>
> 
> After switching to the new FSL QSPI driver the properties 
> 'fsl,qspi-has-second-
> chip' and 'big-endian' are not used anymore.
> 
> The driver now uses the 'reg' property to determine the bus and the 
> chipselect.
> The endianness is selected by the driver depending on which SoC is used.
> 
> Signed-off-by: Frieder Schrempf <[email protected]>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 -
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 --
>  2 files changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index 6fd6116509cc..2fb8138c6bb0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -296,7 +296,6 @@
>                       interrupts = <0 99 0x4>;
>                       clock-names = "qspi_en", "qspi";
>                       clocks = <&clockgen 4 0>, <&clockgen 4 0>;
> -                     big-endian;
>                       status = "disabled";
>               };
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index cb7185014d3a..b0ef08b090dd 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -215,8 +215,6 @@
>                       interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
>                       clock-names = "qspi_en", "qspi";
>                       clocks = <&clockgen 4 1>, <&clockgen 4 1>;
> -                     big-endian;
> -                     fsl,qspi-has-second-chip;
>                       status = "disabled";
>               };
> 
> --
> 2.17.1

Reply via email to