> You must have a reason, but why didn't you completely remove > pciehp_green_led_on(), etc, and change the callers to use > pciehp_set_indicators() instead?
Well, I don't have the exact reason here. I thought that it would be nice to
preserve
an existing interface and to hide some implementation details (e.g., status of
the
second indicator). I could completely remove pciehp_green_led_{on,off,blink}()
and
pciehp_set_attention_status() in v3 if you prefer.
Thanks,
Denis
