This is vastly improved code, thank you! 1) Since we're still duking it out over the meaning of the bits - not just the SCE thing, but as best as I can tell (but could be wrong) the NQB idea wants to put something into the l4s fast queue? Or is NQB supposed to be a third queue?
In those cases, the ecn_mask should just be mask. 2) Is the intent to make the drop probability 0 by default? (10 in the pie rfc, not mentioned in the l4s rfc as yet) 3) has this been tested on a hw mq system as yet? (10gigE is typically 64 queues)