On Fri, 23 Aug 2019 17:21:33 +0800 zhangfei <[email protected]> wrote:
> Hi, Jonathan > > Thanks for your careful review and good suggestion. > Sorry for late response, I am checking one detail. > > On 2019/8/16 上午12:54, Jonathan Cameron wrote: > > On Wed, 14 Aug 2019 17:34:25 +0800 > > Zhangfei Gao <[email protected]> wrote: > > > >> From: Kenneth Lee <[email protected]> > >> > >> Uacce is the kernel component to support WarpDrive accelerator > >> framework. It provides register/unregister interface for device drivers > >> to expose their hardware resource to the user space. The resource is > >> taken as "queue" in WarpDrive. > > It's a bit confusing to have both the term UACCE and WarpDrive in here. > > I'd just use the uacce name in all comments etc. > Yes, make sense > > > >> Uacce create a chrdev for every registration, the queue is allocated to > >> the process when the chrdev is opened. Then the process can access the > >> hardware resource by interact with the queue file. By mmap the queue > >> file space to user space, the process can directly put requests to the > >> hardware without syscall to the kernel space. > >> > >> Uacce also manages unify addresses between the hardware and user space > >> of the process. So they can share the same virtual address in the > >> communication. > >> > >> Signed-off-by: Kenneth Lee <[email protected]> > >> Signed-off-by: Zaibo Xu <[email protected]> > >> Signed-off-by: Zhou Wang <[email protected]> > >> Signed-off-by: Zhangfei Gao <[email protected]> > > I would strip this back to which ever case is of most interest (SVA I > > guess?) > > and only think about adding support for the others if necessary at a later > > date. > > (or in later patches). > Do you mean split the patch and send sva part first? Yes. Either send them as two series with SVA only in the first one, or a single series with SVA only in the early patches. I want to be able to review one case first then only consider what needs to be added for the others. Thanks, Jonathan
