On Wed, 2019-08-28 at 19:51 +0200, Krzysztof Wilczynski wrote: > Add missing log facility where two instances of printk() that did not > use any (so it would be using MESSAGE_LOGLEVEL_DEFAULT set in Kconfig) > to make all the warnings in the arch/x86/pci/pcbios.c to be printed > consistently at the same log facility. Also resolve the following > checkpatch.pl script warning: > > WARNING: printk() should include KERN_<LEVEL> facility level > > While adding the missing log facility move over to using pr_ macros > over using printk(KERN_<level> ...) and DBG(). > > Signed-off-by: Krzysztof Wilczynski <[email protected]> > --- > Changes in v2: > Change wording and include checkpatch.pl script warning. > Leverage pr_fmt and remove "PCI: " prefix used throught. > Move to pr_debug() over using DBG() from arch/x86/include/asm/pci_x86.h.
You might also consider the checkpatch output for this patch. arch/x86/pci/pcbios.c:116: WARNING: line over 80 characters arch/x86/pci/pcbios.c:116: WARNING: Prefer using '"%s...", __func__' to using 'bios32_service', this function's name, in a string arch/x86/pci/pcbios.c:119: WARNING: Prefer using '"%s...", __func__' to using 'bios32_service', this function's name, in a string arch/x86/pci/pcbios.c:391: WARNING: line over 80 characters
