On Wed, Sep 11, 2019 at 8:36 PM Krzysztof Kozlowski <k...@kernel.org> wrote: > > Hi, > > Unfortunately the patches were applied right after closing the linux-next.
Hi Krzysztof, I took a look at these and am not convinced this is right: > 1. Fix boot of Exynos7 due to wrong address/size of memory node, The current state is clearly broken and a fix is needed, but I'm not sure this is the right fix. Why do you have 32-bit physical addressing on a 64-bit chip? I looked at commit ef72171b3621 that introduced it, and it seems it would be better to just revert back to 64-bit addresses. > 2. Move GPU under /soc node, No problem > 3. Minor cleanup of #address-cells. IIRC, an interrupt-controller is required to have a #address-cells property, even if that is normally zero. I don't remember the details, but the gic binding lists it as mandatory, and I think the PCI interrupt-map relies on it. I would just drop this patch. Arnd