On Fri, Sep 20, 2019 at 8:41 AM Ilie Halip <ilie.ha...@gmail.com> wrote: > > When building with ppc64_defconfig, the compiler reports > that these 2 variables are not used: > warning: unused variable 'core99_l2_cache' [-Wunused-variable] > warning: unused variable 'core99_l3_cache' [-Wunused-variable] > > They are only used when CONFIG_PPC64 is not defined. Move > them into a section which does the same macro check. > > Reported-by: Nathan Chancellor <natechancel...@gmail.com> > Signed-off-by: Ilie Halip <ilie.ha...@gmail.com>
Hi Ilie, thanks for the patch. LGTM (Please include link tags if your link addresses a bug in our bug tracker; it helps us track where/when patches land, in case they need to be backported). Reviewed-by: Nick Desaulniers <ndesaulni...@google.com> Link: https://github.com/ClangBuiltLinux/linux/issues/663 > --- > arch/powerpc/platforms/powermac/smp.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/platforms/powermac/smp.c > b/arch/powerpc/platforms/powermac/smp.c > index f95fbdee6efe..e44c606f119e 100644 > --- a/arch/powerpc/platforms/powermac/smp.c > +++ b/arch/powerpc/platforms/powermac/smp.c > @@ -648,6 +648,10 @@ static void smp_core99_pfunc_tb_freeze(int freeze) > > static unsigned int core99_tb_gpio; /* Timebase freeze GPIO */ > > +/* L2 and L3 cache settings to pass from CPU0 to CPU1 on G4 cpus */ > +volatile static long int core99_l2_cache; > +volatile static long int core99_l3_cache; > + > static void smp_core99_gpio_tb_freeze(int freeze) > { > if (freeze) > @@ -660,10 +664,6 @@ static void smp_core99_gpio_tb_freeze(int freeze) > > #endif /* !CONFIG_PPC64 */ > > -/* L2 and L3 cache settings to pass from CPU0 to CPU1 on G4 cpus */ > -volatile static long int core99_l2_cache; > -volatile static long int core99_l3_cache; > - > static void core99_init_caches(int cpu) > { > #ifndef CONFIG_PPC64 > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google Groups > "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/20190920153951.25762-1-ilie.halip%40gmail.com. -- Thanks, ~Nick Desaulniers