On 9/20/19 10:02 AM, Tal Gilboa wrote: > On 9/20/2019 4:31 PM, Uwe Kleine-König wrote: >> According to Tal Gilboa the only benefit from DIM comes from a driver >> that uses it. So it doesn't make sense to make this symbol user visible, >> instead all drivers that use it should select it (as is already the case >> AFAICT). >> >> Signed-off-by: Uwe Kleine-König <[email protected]> >> --- >> lib/Kconfig | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/lib/Kconfig b/lib/Kconfig >> index cc04124ed8f7..9fe8a21fd183 100644 >> --- a/lib/Kconfig >> +++ b/lib/Kconfig >> @@ -555,8 +555,7 @@ config SIGNATURE >> Implementation is done using GnuPG MPI library >> >> config DIMLIB >> - bool "DIM library" >> - default y >> + bool >> help >> Dynamic Interrupt Moderation library. >> Implements an algorithm for dynamically change CQ moderation values >> > There's a pending series using DIM which didn't add the select clause > [1]. Arthur, FYI. Other than that LGTM.
That's easy enough to fix. > [1] https://www.mail-archive.com/[email protected]/msg314304.html for the patch: Acked-by: Randy Dunlap <[email protected]> -- ~Randy
