On Tue, Sep 24, 2019 at 1:21 AM Andy Shevchenko <[email protected]> wrote: > > On Mon, Sep 23, 2019 at 07:49:58PM -0700, Dmitry Torokhov wrote: > > This is essentially a revert of: > > > > e3f72b749da2 pinctrl: cherryview: fix Strago DMI workaround > > 86c5dd6860a6 pinctrl: cherryview: limit Strago DMI workarounds to version > > 1.0 > > > > because even with 1.1 versions of BIOS there are some pins that are > > configured as interrupts but not claimed by any driver, and they > > sometimes fire up and result in interrupt storms that cause touchpad > > stop functioning and other issues. > > > > Given that we are unlikely to qualify another firmware version for a > > while it is better to keep the workaround active on all Strago boards. > > Reviewed-by: Andy Shevchenko <[email protected]>
Tested-by: Alex Levin <[email protected]> > > > > > Reported-by: Alex Levin <[email protected]> > > Fixes: 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to > > version 1.0") > > Cc: [email protected] > > Signed-off-by: Dmitry Torokhov <[email protected]> > > --- > > drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c > > b/drivers/pinctrl/intel/pinctrl-cherryview.c > > index 03ec7a5d9d0b..bf049d1bbb87 100644 > > --- a/drivers/pinctrl/intel/pinctrl-cherryview.c > > +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c > > @@ -1513,7 +1513,6 @@ static const struct dmi_system_id chv_no_valid_mask[] > > = { > > .matches = { > > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > > DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"), > > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"), > > }, > > }, > > { > > @@ -1521,7 +1520,6 @@ static const struct dmi_system_id chv_no_valid_mask[] > > = { > > .matches = { > > DMI_MATCH(DMI_SYS_VENDOR, "HP"), > > DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"), > > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"), > > }, > > }, > > { > > @@ -1529,7 +1527,6 @@ static const struct dmi_system_id chv_no_valid_mask[] > > = { > > .matches = { > > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > > DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"), > > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"), > > }, > > }, > > { > > @@ -1537,7 +1534,6 @@ static const struct dmi_system_id chv_no_valid_mask[] > > = { > > .matches = { > > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > > DMI_MATCH(DMI_PRODUCT_NAME, "Celes"), > > - DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"), > > }, > > }, > > {} > > -- > > 2.23.0.351.gc4317032e6-goog > > > > > > -- > > Dmitry > > -- > With Best Regards, > Andy Shevchenko > >
