On Wed, Sep 18, 2019 at 02:35:51PM -0400, Sven Van Asbroeck wrote: > Add the FL-NET device type to the fieldbus core.
What does this mean? > > Signed-off-by: Sven Van Asbroeck <[email protected]> > --- > .../fieldbus/Documentation/ABI/sysfs-class-fieldbus-dev | 1 + > drivers/staging/fieldbus/dev_core.c | 3 +++ > drivers/staging/fieldbus/fieldbus_dev.h | 1 + > 3 files changed, 5 insertions(+) > > diff --git > a/drivers/staging/fieldbus/Documentation/ABI/sysfs-class-fieldbus-dev > b/drivers/staging/fieldbus/Documentation/ABI/sysfs-class-fieldbus-dev > index 439f14d33c3b..233c418016aa 100644 > --- a/drivers/staging/fieldbus/Documentation/ABI/sysfs-class-fieldbus-dev > +++ b/drivers/staging/fieldbus/Documentation/ABI/sysfs-class-fieldbus-dev > @@ -12,6 +12,7 @@ Description: > Possible values: > 'unknown' > 'profinet' > + 'flnet' > > What: /sys/class/fieldbus_dev/fieldbus_devX/fieldbus_id > KernelVersion: 5.1 (staging) > diff --git a/drivers/staging/fieldbus/dev_core.c > b/drivers/staging/fieldbus/dev_core.c > index 9903c4f3cba9..7e9405e52f19 100644 > --- a/drivers/staging/fieldbus/dev_core.c > +++ b/drivers/staging/fieldbus/dev_core.c > @@ -113,6 +113,9 @@ static ssize_t fieldbus_type_show(struct device *dev, > case FIELDBUS_DEV_TYPE_PROFINET: > t = "profinet"; > break; > + case FIELDBUS_DEV_TYPE_FLNET: > + t = "flnet"; > + break; > default: > t = "unknown"; > break; > diff --git a/drivers/staging/fieldbus/fieldbus_dev.h > b/drivers/staging/fieldbus/fieldbus_dev.h > index 3b00315600e5..f775546b3404 100644 > --- a/drivers/staging/fieldbus/fieldbus_dev.h > +++ b/drivers/staging/fieldbus/fieldbus_dev.h > @@ -15,6 +15,7 @@ struct fieldbus_dev_config; > enum fieldbus_dev_type { > FIELDBUS_DEV_TYPE_UNKNOWN = 0, > FIELDBUS_DEV_TYPE_PROFINET, > + FIELDBUS_DEV_TYPE_FLNET You add an unspecified enumerated type and suddenly new hardware starts working? That feels really wrong to me... greg k-h
