On Thu, Sep 26, 2019 at 10:46:24AM +0530, Shubhrajyoti Datta wrote:
> Add dt bindings for flexnoc Performance Monitor.
> The flexnoc counters for read and write response and requests are
> supported.
> 
> Signed-off-by: Shubhrajyoti Datta <[email protected]>
> ---
>  .../devicetree/bindings/misc/xlnx,flexnoc.txt      | 24 
> ++++++++++++++++++++++

bindings/perf/

Please convert this to a schema. See 
Documentation/devicetree/writing-schema.rst.

>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> 
> diff --git a/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt 
> b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> new file mode 100644
> index 0000000..6b533bc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> @@ -0,0 +1,24 @@
> +* Xilinx Flexnoc Performance Monitor driver

Bindings are for h/w blocks, not drivers.

> +
> +The FlexNoc Performance Monitor has counters for monitoring
> +the read and the write transaction counter.
> +
> +Required properties:
> +- compatible: "xlnx,flexnoc-pm-2.7"
> +- reg : Address and length of register sets for each device in
> +       "reg-names"
> +- reg-names : The names of the register addresses corresponding to the
> +               registers filled in "reg"
> +               - funnel: base address of the funnel registers
> +               - baselpd: base address of the LPD PM registers
> +               - basefpd: base address FPD PM registers

Is this really all one h/w block.

FlexNoC is an interconnect, right? Is there more to it than just 
perfmon?

> +
> +Example:
> +++++++++
> +performance-monitor@f0920000 {
> +               compatible = "xlnx,flexnoc-pm-2.7";
> +               reg-names = "funnel", "baselpd", "basefpd";
> +               reg = <0x0 0xf0920000 0x0 0x1000>,
> +                       <0x0 0xf0980000 0x0 0x9000>,
> +                       <0x0 0xf0b80000 0x0 0x9000>;
> +};
> --
> 2.1.1
> 
> This email and any attachments are intended for the sole use of the named 
> recipient(s) and contain(s) confidential information that may be proprietary, 
> privileged or copyrighted under applicable law. If you are not the intended 
> recipient, do not read, copy, or forward this email message or any 
> attachments. Delete this email message and any attachments immediately.

We can't accept confidential emails.

Rob

Reply via email to