Em Fri, Oct 11, 2019 at 05:19:41PM +0800, Leo Yan escreveu:
> When fail to mmap events in task exit case, it misses to set 'err' to
> -1; thus the testing will not report failure for it.
> 
> This patch sets 'err' to -1 when fails to mmap events, thus Perf tool
> can report correct result.

Thanks, applied and added:

Fixes: d723a55096b8 ("perf test: Add test case for checking number of EXIT 
events")


 
> Signed-off-by: Leo Yan <[email protected]>
> ---
>  tools/perf/tests/task-exit.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c
> index bce3a4cb4c89..ca0a6ca43b13 100644
> --- a/tools/perf/tests/task-exit.c
> +++ b/tools/perf/tests/task-exit.c
> @@ -110,6 +110,7 @@ int test__task_exit(struct test *test __maybe_unused, int 
> subtest __maybe_unused
>       if (evlist__mmap(evlist, 128) < 0) {
>               pr_debug("failed to mmap events: %d (%s)\n", errno,
>                        str_error_r(errno, sbuf, sizeof(sbuf)));
> +             err = -1;
>               goto out_delete_evlist;
>       }
>  
> -- 
> 2.17.1

-- 

- Arnaldo

Reply via email to