Re: [PATCH 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs

[Sibi Sankar]

Hey Bjorn,

On 2020-04-28 05:31, Bjorn Andersson wrote:

Add audio, compute and sensor DSP compatibles to the Qualcomm PAS
binding and driver.

Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org>
---
 drivers/remoteproc/qcom_q6v5_pas.c | 62 ++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c
b/drivers/remoteproc/qcom_q6v5_pas.c
index 8ecc157f1ed1..5f2266c74448 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c

@@ -508,6 +508,26 @@ static const struct adsp_data sm8150_adsp_resource = {

                .ssctl_id = 0x14,
 };

+static const struct adsp_data sm8250_adsp_resource = {
+       .crash_reason_smem = 423,
+       .firmware_name = "adsp.mdt",
+       .pas_id = 1,
+       .has_aggre2_clk = false,
+       .auto_boot = true,
+       .active_pd_names = (char*[]){
+               "load_state",
+               NULL
+       },
+       .proxy_pd_names = (char*[]){
+               "cx",
+               "mx",

you may want to name it as lcx, lmx.
The remaining looks good!

Reviewed-by: Sibi Sankar <si...@codeaurora.org>

+               NULL
+       },
+       .ssr_name = "lpass",
+       .sysmon_name = "adsp",
+       .ssctl_id = 0x14,
+};
+
 static const struct adsp_data msm8998_adsp_resource = {
                .crash_reason_smem = 423,
                .firmware_name = "adsp.mdt",

@@ -553,6 +573,25 @@ static const struct adsp_data sm8150_cdsp_resource = {

        .ssctl_id = 0x17,
 };

+static const struct adsp_data sm8250_cdsp_resource = {
+       .crash_reason_smem = 601,
+       .firmware_name = "cdsp.mdt",
+       .pas_id = 18,
+       .has_aggre2_clk = false,
+       .auto_boot = true,
+       .active_pd_names = (char*[]){
+               "load_state",
+               NULL
+       },
+       .proxy_pd_names = (char*[]){
+               "cx",
+               NULL
+       },
+       .ssr_name = "cdsp",
+       .sysmon_name = "cdsp",
+       .ssctl_id = 0x17,
+};
+
 static const struct adsp_data mpss_resource_init = {
        .crash_reason_smem = 421,
        .firmware_name = "modem.mdt",

@@ -604,6 +643,26 @@ static const struct adsp_data sm8150_slpi_resource = {

                .ssctl_id = 0x16,
 };

+static const struct adsp_data sm8250_slpi_resource = {
+       .crash_reason_smem = 424,
+       .firmware_name = "slpi.mdt",
+       .pas_id = 12,
+       .has_aggre2_clk = false,
+       .auto_boot = true,
+       .active_pd_names = (char*[]){
+               "load_state",
+               NULL
+       },
+       .proxy_pd_names = (char*[]){
+               "lcx",
+               "lmx",
+               NULL
+       },
+       .ssr_name = "dsps",
+       .sysmon_name = "slpi",
+       .ssctl_id = 0x16,
+};
+
 static const struct adsp_data msm8998_slpi_resource = {
                .crash_reason_smem = 424,
                .firmware_name = "slpi.mdt",

@@ -644,6 +703,9 @@ static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,sm8150-cdsp-pas", .data = &sm8150_cdsp_resource},

        { .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init},

{ .compatible = "qcom,sm8150-slpi-pas", .data = &sm8150_slpi_resource}, + { .compatible = "qcom,sm8250-adsp-pas", .data = &sm8250_adsp_resource}, + { .compatible = "qcom,sm8250-cdsp-pas", .data = &sm8250_cdsp_resource}, + { .compatible = "qcom,sm8250-slpi-pas", .data = &sm8250_slpi_resource},

        { },
 };
 MODULE_DEVICE_TABLE(of, adsp_of_match);

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.