> > > @@ -8441,7 +8441,8 @@ int ufshcd_init(struct ufs_hba *hba, void
> > > __iomem *mmio_base, unsigned int irq)
> > >   if ((hba->ufs_version != UFSHCI_VERSION_10) &&
> > >       (hba->ufs_version != UFSHCI_VERSION_11) &&
> > >       (hba->ufs_version != UFSHCI_VERSION_20) &&
> > > -     (hba->ufs_version != UFSHCI_VERSION_21))
> > > +     (hba->ufs_version != UFSHCI_VERSION_21) &&
> > > +     (hba->ufs_version != UFSHCI_VERSION_30))
> >
> > I don't think these checkups of UFSHCI version is necessary,  does the 
> > UFSHCI
> have other version number except these?
> > Is there somebody still v1.0 and v1.1?
> 
> Probably. I think we can leave them or change the dev_err to a dev_warn.
> This way we have logs in case someone is using a non-supported version.
> 
> What do you think ?
> 
Hi, Jose
Seems after your patch, all of current released UFS control versions will be 
supported except the
version suffix is non-zero. Right?

> ---
> Thanks,
> Jose Miguel Abreu

Reply via email to