Hi,
On Tue 28 Apr 20, 23:50, Arnd Bergmann wrote:
> Older compilers warn about initializers with incorrect curly
> braces:
>
> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function
> 'sun6i_dsi_encoder_enable':
> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: missing braces around
> initializer [-Werror=missing-braces]
> union phy_configure_opts opts = { 0 };
> ^
> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: (near initialization for
> 'opts.mipi_dphy') [-Werror=missing-braces]
>
> Use the GNU empty initializer extension to avoid this.Looks good to me: Reviewed-by: Paul Kocialkowski <[email protected]> But maybe use the drm/sun4i: dsi: prefix instead (granted, it wasn't used in the commit being fixed). Cheers, Paul > Fixes: bb3b6fcb6849 ("sun6i: dsi: Convert to generic phy handling") > Signed-off-by: Arnd Bergmann <[email protected]> > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index f6c67dd87a05..aa67cb037e9d 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -718,7 +718,7 @@ static void sun6i_dsi_encoder_enable(struct drm_encoder > *encoder) > struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode; > struct sun6i_dsi *dsi = encoder_to_sun6i_dsi(encoder); > struct mipi_dsi_device *device = dsi->device; > - union phy_configure_opts opts = { 0 }; > + union phy_configure_opts opts = { }; > struct phy_configure_opts_mipi_dphy *cfg = &opts.mipi_dphy; > u16 delay; > int err; > -- > 2.26.0 > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
signature.asc
Description: PGP signature
