On Tue, Apr 28, 2020 at 07:45:19PM +0800, Jiaxun Yang wrote: > > > 于 2020年4月28日 GMT+08:00 下午7:33:26, Thomas Bogendoerfer > <[email protected]> 写到: > >On Tue, Apr 28, 2020 at 10:14:12AM +0800, Jiaxun Yang wrote: > >> That would allow us modify kernel vm address spaces without > >> step into the hell of includes. > >> > >> Also use some marcos for address spaces to make spaces.h more > >> clear. > >> > >> Signed-off-by: Jiaxun Yang <[email protected]> > > > >I don't like this patch as I can't see a good reason for shuffling > >stuff arround. Can you drop this from this series ? > > The problem is without this patch we'll have to include pgtable-32.h and > pgtable-64.h into asm/io.h, and that will become totally hell.
sure, but this would just mean moving VMALLOC_START, but not the other stuff in this patch, which is more what I dislike... Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
