On Mon, 11 May 2020 22:49:28 +0530 "Alim Akhtar" <[email protected]> wrote:
> Hello Krzysztof, > Thanks for the patch. > > > -----Original Message----- > > From: Krzysztof Kozlowski <[email protected]> > > Sent: 11 May 2020 14:04 > > To: Jonathan Cameron <[email protected]>; Hartmut Knaack > > <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald- > > Stadler <[email protected]>; Kukjin Kim <[email protected]>; Krzysztof > > Kozlowski <[email protected]>; [email protected]; linux-arm- > > [email protected]; [email protected]; linux- > > [email protected] > > Cc: Alim Akhtar <[email protected]> > > Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init > > > > The Exynos7-specific code bits in ADC driver do not play with PHY: > > the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data > > instance. Therefore the initialization code does not have to check if it > is true. > > > > Signed-off-by: Krzysztof Kozlowski <[email protected]> > > > Reviewed-by: Alim Akhtar <[email protected]> > Tested on exynos7-espresso board so, > Tested-by: Alim Akhtar <[email protected]> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > > --- > > > > Only build tested. > > --- > > drivers/iio/adc/exynos_adc.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c > index > > 22131a677445..219c8eb32d16 100644 > > --- a/drivers/iio/adc/exynos_adc.c > > +++ b/drivers/iio/adc/exynos_adc.c > > @@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct > > exynos_adc *info) { > > u32 con1, con2; > > > > - if (info->data->needs_adc_phy) > > - regmap_write(info->pmu_map, info->data->phy_offset, 1); > > - > > con1 = ADC_V2_CON1_SOFT_RESET; > > writel(con1, ADC_V2_CON1(info->regs)); > > > > -- > > 2.17.1 > >
