Re: [PATCH] clk/ti/adpll: Add a NULL check for devm_kasprintf()

[Joe Perches]

On Mon, 2020-05-18 at 03:46 +0000, Xu Wang wrote:
> devm_kasprintf() may fail, so we should better add a NULL check
> and propagate an error on failure.

You didn't compile this.

All the return values of this function are already checked.

> Signed-off-by: Xu Wang <vu...@iscas.ac.cn>
> ---
>  drivers/clk/ti/adpll.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
> index bb2f283..f18a672 100644
> --- a/drivers/clk/ti/adpll.c
> +++ b/drivers/clk/ti/adpll.c
> @@ -196,6 +196,8 @@ static const char *ti_adpll_clk_get_name(struct 
> ti_adpll_data *d,
>       } else {
>               name = devm_kasprintf(d->dev, GFP_KERNEL, "%08lx.adpll.%s",
>                                     d->pa, postfix);
> +             if (!name)
> +                     return -ENOMEM;
>       }
>  
>       return name;