Hi Xu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v5.7-rc6 next-20200515]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    
https://github.com/0day-ci/linux/commits/Xu-Wang/clk-ti-adpll-Add-a-NULL-check-for-devm_kasprintf/20200518-114748
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 
135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <[email protected]>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/clk/ti/adpll.c:200:11: warning: incompatible integer to pointer 
>> conversion returning 'int' from a function with result type 'const char *' 
>> [-Wint-conversion]
return -ENOMEM;
^~~~~~~
1 warning generated.

vim +200 drivers/clk/ti/adpll.c

   181  
   182  static const char *ti_adpll_clk_get_name(struct ti_adpll_data *d,
   183                                           int output_index,
   184                                           const char *postfix)
   185  {
   186          const char *name;
   187          int err;
   188  
   189          if (output_index >= 0) {
   190                  err = of_property_read_string_index(d->np,
   191                                                      
"clock-output-names",
   192                                                      output_index,
   193                                                      &name);
   194                  if (err)
   195                          return NULL;
   196          } else {
   197                  name = devm_kasprintf(d->dev, GFP_KERNEL, 
"%08lx.adpll.%s",
   198                                        d->pa, postfix);
   199                  if (!name)
 > 200                          return -ENOMEM;
   201          }
   202  
   203          return name;
   204  }
   205  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

Reply via email to