"off by on" or
"off by one" ? M >-----Original Message----- >From: dri-devel <[email protected]> On Behalf Of Dan >Carpenter >Sent: Wednesday, May 20, 2020 9:08 AM >To: Alex Deucher <[email protected]>; Kevin Wang ><[email protected]> >Cc: David Airlie <[email protected]>; [email protected]; linux- >[email protected]; [email protected]; Hawking Zhang ><[email protected]>; Rui Huang <[email protected]>; dri- >[email protected]; Evan Quan <[email protected]>; Kenneth >Feng <[email protected]>; Christian König ><[email protected]>; Yintian Tao <[email protected]> >Subject: [PATCH v2] drm/amdgpu: off by on in >amdgpu_device_attr_create_groups() error handling > >This loop in the error handling code should start a "i - 1" and end at >"i == 0". Currently it starts a "i" and ends at "i == 1". The result >is that it removes one attribute that wasn't created yet, and leaks the >zeroeth attribute. > >Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device attribute code") >Signed-off-by: Dan Carpenter <[email protected]> >--- >v2: style change > > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > >diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c >b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c >index b75362bf0742..e809534fabd4 100644 >--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c >+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c >@@ -1942,9 +1942,8 @@ static int amdgpu_device_attr_create_groups(struct >amdgpu_device *adev, > return 0; > > failed: >- for (; i > 0; i--) { >+ while (i--) > amdgpu_device_attr_remove(adev, &attrs[i]); >- } > > return ret; > } >_______________________________________________ >dri-devel mailing list >[email protected] >https://lists.freedesktop.org/mailman/listinfo/dri-devel
