Am 20.05.20 um 17:31 schrieb Ruhl, Michael J:
-----Original Message----- From: Dan Carpenter <[email protected]> Sent: Wednesday, May 20, 2020 11:26 AM To: Alex Deucher <[email protected]>; Kevin Wang <[email protected]>; Ruhl, Michael J <[email protected]> Cc: Christian König <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Evan Quan <[email protected]>; Rui Huang <[email protected]>; Kenneth Feng <[email protected]>; Yintian Tao <[email protected]>; Hawking Zhang <[email protected]>; [email protected]; dri- [email protected]; [email protected]; kernel- [email protected] Subject: [PATCH v3] drm/amdgpu: off by one in amdgpu_device_attr_create_groups() error handlingThis loop in the error handling code should start a "i - 1" and end at "i == 0". Currently it starts a "i" and ends at "i == 1". The result is that it removes one attribute that wasn't created yet, and leaks the zeroeth attribute. Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device attribute code") Signed-off-by: Dan Carpenter <[email protected]> --- v2: style change v3: Fix embarrassing typo in the subject😊 Acked-by: Michael J. Ruhl <[email protected]>
Reviewed-by: Christian König <[email protected]>
mdrivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c index b75362bf0742..e809534fabd4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c @@ -1942,9 +1942,8 @@ static int amdgpu_device_attr_create_groups(struct amdgpu_device *adev, return 0; failed: - for (; i > 0; i--) { + while (i--) amdgpu_device_attr_remove(adev, &attrs[i]); - } return ret; }
