On Thu, May 21, 2020 at 6:51 PM Mark Brown <broo...@kernel.org> wrote: > On Thu, May 21, 2020 at 03:12:28PM +0300, Serge Semin wrote: > > > Well, for me both solutions are equal except mine consumes less stack > > memory. > > The only reason why your solution might be better is that if DW DMA driver > > or > > the DMA engine subsystem changed the dw_dma_slave structure instance passed > > to > > the dma_request_channel() method, which non of them do. So I'll leave this > > for > > Mark to decide. Mark, could you give us your final word about this? > > Honestly I'm struggling to care either way. I guess saving a bit of > stack is potentially useful.
Yes, but OTOH dropping maintainability by this is worse in my opinion. -- With Best Regards, Andy Shevchenko