On 5/24/20 8:30 AM, Greg Kroah-Hartman wrote:
> Sometimes it is better to unregister individual nodes instead of trying
> to do them all at once with software_node_unregister_nodes(), so create
> software_node_unregister() so that you can unregister them one at a
> time.
>
> This is especially important when creating nodes in a hierarchy, with
> parent -> children representations. Children always need to be removed
> before a parent is, as the swnode logic assumes this is going to be the
> case.
>
> Fix up the lib/test_printf.c fwnode_pointer() test which to use this new
> function as it had the problem of tearing things down in the backwards
> order.
>
> Fixes: f1ce39df508d ("lib/test_printf: Add tests for %pfw printk modifier")
> Reported-by: Naresh Kamboju <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: stable <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Brendan Higgins <[email protected]>
> Cc: Dmitry Torokhov <[email protected]>
> Cc: Heikki Krogerus <[email protected]>
> Cc: Petr Mladek <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: Rasmus Villemoes <[email protected]>
> Cc: Sakari Ailus <[email protected]>
> Cc: Sergey Senozhatsky <[email protected]>
> Cc: Steven Rostedt <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Both patches pass my boot tests on arm64 and arm64be (I didn't test any others).
So, FWIW,
Tested-by: Guenter Roeck <[email protected]>
I wasn't sure it the two patches replace or fix commit 4ef12f719802 ("kobject:
Make sure the parent does not get released before its children"), so I tried
to re-apply 4ef12f719802 on top of the two patches. Unfortunately that still
results in crashes and UAF messages.
Guenter
