Hi Xu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v5.7-rc7 next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    
https://github.com/0day-ci/linux/commits/Xu-Wang/clk-ti-adpll-Add-a-NULL-check-for-devm_kasprintf/20200518-114748
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: x86_64-randconfig-s021-20200527 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-240-gf0fe1cd9-dirty
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <l...@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/clk/ti/adpll.c:200:32: sparse: sparse: incorrect type in return 
>> expression (different base types) @@     expected char const * @@     got 
>> int @@
   drivers/clk/ti/adpll.c:200:32: sparse:     expected char const *
   drivers/clk/ti/adpll.c:200:32: sparse:     got int

vim +200 drivers/clk/ti/adpll.c

   181  
   182  static const char *ti_adpll_clk_get_name(struct ti_adpll_data *d,
   183                                           int output_index,
   184                                           const char *postfix)
   185  {
   186          const char *name;
   187          int err;
   188  
   189          if (output_index >= 0) {
   190                  err = of_property_read_string_index(d->np,
   191                                                      
"clock-output-names",
   192                                                      output_index,
   193                                                      &name);
   194                  if (err)
   195                          return NULL;
   196          } else {
   197                  name = devm_kasprintf(d->dev, GFP_KERNEL, 
"%08lx.adpll.%s",
   198                                        d->pa, postfix);
   199                  if (!name)
 > 200                          return -ENOMEM;
   201          }
   202  
   203          return name;
   204  }
   205  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to