On 2020-05-28 04:56, Bean Huo wrote: > From: Bean Huo <[email protected]> > > For the UFS device, the maximum descriptor size is 255, max_t called in > ufs_get_device_desc() is useless. > > Signed-off-by: Bean Huo <[email protected]> > --- > drivers/scsi/ufs/ufshcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index aca50ed39844..0f8c7e05df29 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -6881,8 +6881,7 @@ static int ufs_get_device_desc(struct ufs_hba *hba) > u8 *desc_buf; > struct ufs_dev_info *dev_info = &hba->dev_info; > > - buff_len = max_t(size_t, hba->desc_size.dev_desc, > - QUERY_DESC_MAX_SIZE + 1); > + buff_len = QUERY_DESC_MAX_SIZE + 1; > desc_buf = kmalloc(buff_len, GFP_KERNEL); > if (!desc_buf) { > err = -ENOMEM;
Since the buff_len variable is not changed after its initial assignment, please remove it entirely. Thanks, Bart.
