On Thu, 2020-05-28 at 14:58 +0000, Avri Altman wrote: > Hi, > > > From: Bean Huo <[email protected]> > > > > At UFS initialization stage, to get the length of the descriptor, > > ufshcd_read_desc_length() being called 6 times. > > May I suggest one more clarifying sentence to your commit log: > "Instead, we will capture the descriptor size the first time we'll > read it." > > > This patch is to > > delete unnecessary reduntant code, remove ufshcd_read_desc_length() > > typo: redundant
fixed. > > > and boost UFS initialization. > > > > Signed-off-by: Bean Huo <[email protected]> > > + if (desc_id >= QUERY_DESC_IDN_MAX) { > > *desc_len = 0; > > return -EINVAL; > > } > > if (desc_id == QUERY_DESC_IDN_RFU_0 || desc_id == > QUERY_DESC_IDN_RFU_1) > *desc_len = 0; > else > > + > > + *desc_len = hba->desc_size[desc_id]; > > return 0; > > } > > EXPORT_SYMBOL(ufshcd_map_desc_id_to_length); > > > > +static void ufshcd_update_desc_length(struct ufs_hba *hba, > > + enum desc_idn desc_id, int > > desc_len) > > desc_len is at most 255 so maybe u8? > Avri thanks, it will be changed in next version. Bean
