2020년 6월 9일 (화) 오후 11:04, Michal Hocko <mho...@kernel.org>님이 작성: > > On Wed 27-05-20 15:44:59, Joonsoo Kim wrote: > > From: Joonsoo Kim <iamjoonsoo....@lge.com> > > > > To prepare unifying duplicated functions in following patches, this patch > > changes the interface of the migration target alloc/free functions. > > Functions now use struct alloc_control as an argument. > > It also pulls private argument into alloc_control and keeps it that way. > Wouldn't it be better to use explicit types and names in a union? Each > allocation callback has to understant the meaning anyway. I would > consider the resulting code cleaner that way. What do you think?
Your suggestion sounds reasonable. Thanks. My plan is that, as Vlastimil suggested, I will keep the private argument in migration callback and use the appropriate private argument by the allocation caller. There will be no private field on alloc_control. Thanks.
