On 24/04/2020 21:56, Guilherme Ricioli wrote:
> Fix checkpatch error "ERROR: Macros with complex values should be
> enclosed in parentheses" in soc_camera.c:241.
>
> Signed-off-by: Guilherme Ricioli <[email protected]>
> ---
> drivers/staging/media/soc_camera/soc_camera.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/soc_camera/soc_camera.c
> b/drivers/staging/media/soc_camera/soc_camera.c
> index 39f513f..c2f96ea 100644
> --- a/drivers/staging/media/soc_camera/soc_camera.c
> +++ b/drivers/staging/media/soc_camera/soc_camera.c
> @@ -238,8 +238,8 @@ unsigned long soc_camera_apply_board_flags(struct
> soc_camera_subdev_desc *ssdd,
> }
> EXPORT_SYMBOL(soc_camera_apply_board_flags);
>
> -#define pixfmtstr(x) (x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \
> - ((x) >> 24) & 0xff
> +#define pixfmtstr(x) ((x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \
> + ((x) >> 24) & 0xff)
>
> static int soc_camera_try_fmt(struct soc_camera_device *icd,
> struct v4l2_format *f)
>
Thank you for the patch, but this driver is deprecated and in fact depends on
BROKEN
(so it is never build).
Because of that I'll drop this patch.
Regards,
Hans
