On Mon, Jun 29, 2020 at 01:47:49PM +0100, Lee Jones wrote: > 'duty' here is an unsigned int, thus checking for <0 will always > evaluate to false. > > Fixes the following W=1 warning: > > drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned > expression < 0 is always false [-Wtype-limits] > > Cc: Ray Jui <[email protected]> > Cc: Scott Branden <[email protected]> > Cc: Yendapally Reddy Dhananjaya Reddy <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Lee Jones <[email protected]> > --- > drivers/pwm/pwm-bcm-iproc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c > index 1f829edd8ee70..46f0a45e9049c 100644 > --- a/drivers/pwm/pwm-bcm-iproc.c > +++ b/drivers/pwm/pwm-bcm-iproc.c > @@ -143,8 +143,7 @@ static int iproc_pwmc_apply(struct pwm_chip *chip, struct > pwm_device *pwm, > value = rate * state->duty_cycle; > duty = div64_u64(value, div); > > - if (period < IPROC_PWM_PERIOD_MIN || > - duty < IPROC_PWM_DUTY_CYCLE_MIN) > + if (period < IPROC_PWM_PERIOD_MIN) > return -EINVAL; > > if (period <= IPROC_PWM_PERIOD_MAX &&
Acked-by: Uwe Kleine-König <[email protected]> Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
