On 7/14/20 9:40 AM, Paolo Pisati wrote:
> During setup():
> ...
> for ns in h0 r1 h1 h2 h3
> do
> create_ns ${ns}
> done
> ...
>
> while in cleanup():
> ...
> for n in h1 r1 h2 h3 h4
> do
> ip netns del ${n} 2>/dev/null
> done
> ...
>
> and after removing the stderr redirection in cleanup():
>
> $ sudo ./fib_nexthop_multiprefix.sh
> ...
> TEST: IPv4: host 0 to host 3, mtu 1400 [ OK ]
> TEST: IPv6: host 0 to host 3, mtu 1400 [ OK ]
> Cannot remove namespace file "/run/netns/h4": No such file or directory
> $ echo $?
> 1
>
> and a non-zero return code, make kselftests fail (even if the test
> itself is fine):
>
> ...
> not ok 34 selftests: net: fib_nexthop_multiprefix.sh # exit=1
> ...
>
> Signed-off-by: Paolo Pisati <paolo.pis...@canonical.com>
> ---
> tools/testing/selftests/net/fib_nexthop_multiprefix.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/fib_nexthop_multiprefix.sh
> b/tools/testing/selftests/net/fib_nexthop_multiprefix.sh
> index 9dc35a16e415..51df5e305855 100755
> --- a/tools/testing/selftests/net/fib_nexthop_multiprefix.sh
> +++ b/tools/testing/selftests/net/fib_nexthop_multiprefix.sh
> @@ -144,7 +144,7 @@ setup()
>
> cleanup()
> {
> - for n in h1 r1 h2 h3 h4
> + for n in h0 r1 h1 h2 h3
> do
> ip netns del ${n} 2>/dev/null
> done
>
Reviewed-by: David Ahern <dsah...@gmail.com>
