> -----Original Message----- > From: Greg KH <gre...@linuxfoundation.org> > Sent: Friday, July 24, 2020 4:32 PM > To: Bard Liao <yung-chuan.l...@linux.intel.com> > Cc: alsa-de...@alsa-project.org; vk...@kernel.org; vinod.k...@linaro.org; > linux-kernel@vger.kernel.org; ti...@suse.de; broo...@kernel.org; > j...@cadence.com; srinivas.kandaga...@linaro.org; > rander.w...@linux.intel.com; ranjani.sridha...@linux.intel.com; > hui.w...@canonical.com; pierre-louis.boss...@linux.intel.com; Kale, Sanyog > R <sanyog.r.k...@intel.com>; Lin, Mengdong <mengdong....@intel.com>; > Liao, Bard <bard.l...@intel.com> > Subject: Re: [PATCH] soundwire: master: enable pm runtime > > On Thu, Jul 23, 2020 at 09:49:02PM +0800, Bard Liao wrote: > > We should enable pm runtime. > > Because why?
The hierarchy of soundwire devices is platform device -> M device -> S device. A S device is physically attached on the platform device. So the platform device should be resumed when a S device is resumed. As the bridge of platform device and S device, we have to implement runtime pm on M driver. We have set runtime pm ops in M driver already, but still need to enable runtime pm. > > Please read the documentation about how to write good changelog > comments... Sure. I will update the changelog in next version. Thanks for the advice. > > greg k-h
