On Mon, 27 Jul 2020, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 3:57 PM Lee Jones <[email protected]> wrote: > > On Mon, 27 Jul 2020, Andy Shevchenko wrote: > > > On Mon, Jul 27, 2020 at 03:04:07AM +0000, Xu Wang wrote: > > ... > > > > It's a bit more helpful in the original form in case to add some > > > debugging. > > > > If you wish to add debugging, you'll have to add the extra line of > > code yourself. :) > > True, that's why I'm not objecting the change. > > > > It also keep it symmetrical with read() counterpart. > > > > Can this be fixed-up too? > > How? Can you elaborate?
I hadn't even looked at the code before my reply. I just assumed it was in a similar situation. Now I have looked at it, could the pointer to the return value be cast? If not, just leave it. Symmetry isn't a good measure of good, clean code. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
