Re: [PATCH 02/18] spi: stm32-spi: defer probe for reset

[Mark Brown]

On Wed, Aug 05, 2020 at 09:01:57AM +0200, Alain Volmat wrote:

> -     rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> -     if (!IS_ERR(rst)) {
> +     rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL);
> +     if (rst) {
> +             if (IS_ERR(rst)) {
> +                     ret = PTR_ERR(rst);
> +                     if (ret != -EPROBE_DEFER)
> +                             dev_err(&pdev->dev, "reset get failed: %d\n",
> +                                     ret);
> +                     goto err_clk_disable;
> +             }

This will not provide any diagnostics when deferring which isn't very
helpful if there's issues.

signature.asc
Description: PGP signature